Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter should check that the version is increased #659

Open
Ana06 opened this issue Sep 7, 2023 · 1 comment
Open

Linter should check that the version is increased #659

Ana06 opened this issue Sep 7, 2023 · 1 comment
Labels
🏃 CI Related to CI

Comments

@Ana06
Copy link
Member

Ana06 commented Sep 7, 2023

As mentioned in our documentation:

The version needs to be increased every time you modify an existing package.

Otherwise, the higest old version will be installed and tested in our CI and the change in the package won't have effect. The linter should complain about this.

This has been an issue recently in several PR that were using the date as version in the format day.month.year or month.day.year instead of using the tool version. We should use the tool version and not the date. If there is no tool version, the version should be 0.0.0.YYYYMMDD, using the 4th segment for the date. For example:

The linter should check that the version follows the correct format (this is done already) and also that the version has been increased.

All this is already documented in our wiki, but if someone feels it needs more detail, please improve the Wiki as well. 😄

@Ana06 Ana06 added the 🏃 CI Related to CI label Sep 7, 2023
@Ana06 Ana06 added this to the FLARE-VM 2023 Q3 milestone Sep 7, 2023
@Ana06 Ana06 removed this from the FLARE-VM 2023 Q4 milestone Sep 27, 2023
@Ana06
Copy link
Member Author

Ana06 commented Feb 19, 2024

One problem to enforce this in the linter is that it will fail if we decrease the version because it is wrong. We have done this a few times by deleting the current packages in myget. Example: #890 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏃 CI Related to CI
Projects
None yet
Development

No branches or pull requests

1 participant