Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds all Junction, RoadGeometry::get_junction, Segment::junction bindings #51

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Adds all Junction, RoadGeometry::get_junction, Segment::junction bindings #51

merged 3 commits into from
Mar 26, 2024

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Mar 26, 2024 •
edited
Loading

🎉 New feature

❗ Goes on top of #50

Related to #31 #36 #48 #49 #17 #28

Summary

  • maliput::api::Junction FFI bindings and Rust API
  • maliput::api::Segment::junction method
  • maliput::api::RoadGeometry::id method
  • maliput::api::RoadGeometry::get_junction method

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

This was referenced Mar 26, 2024
Open
Open
Closed
Closed
Open
Open
Base automatically changed from francocipollone/segment to main March 26, 2024 15:24
agalbachicar
agalbachicar approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit c06b7ce into main Mar 26, 2024
3 checks passed
@francocipollone francocipollone deleted the francocipollone/junction branch March 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar