Skip to content

Commit

Permalink
breaking(ember support): remove Ember < 3.28 support, disable jquery-…
Browse files Browse the repository at this point in the history
…integration by default
  • Loading branch information
BlueCutOfficial committed Feb 2, 2024
1 parent 54ac991 commit ba20c5b
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 33 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ jobs:
fail-fast: false
matrix:
try-scenario:
- ember-lts-3.4
- ember-lts-3.8
- ember-lts-3.12
- ember-lts-3.28
- ember-lts-4.4
- ember-lts-4.8
- ember-release
- ember-beta
- ember-canary
Expand Down
4 changes: 0 additions & 4 deletions DEPRECATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,3 @@ export class ApplicationController extends Controller {
> Caution: old-style components that have their template in `app/templates/components` instead of co-located next to their Javascript in `app/components` can't work correctly when discovered via their component class, because there's no way to locate the template. They should either port to being co-located (which is a simple mechanical transformation and highly recommended) or should import their own template and set it as layout as was traditional in addons before co-location was available.
-- [Replacing Component Helper.md](https://github.com/embroider-build/embroider/blob/main/docs/replacing-component-helper.md#when-youre-invoking-a-component-youve-been-given)

## Ember < 3.28

The v2 addon will no longer support Ember versions lower than 3.28.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ The better way to handle modals in your Ember.js apps.
## Compatibility

- Ember.js v3.4 or above
- Ember CLI v3.4 or above
- Ember.js v3.28 or above
- Ember CLI v3.28 or above
- Node.js v16 or above

## Installation
Expand Down
30 changes: 6 additions & 24 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,44 +7,26 @@ module.exports = async function () {
usePnpm: true,
scenarios: [
{
name: 'ember-lts-3.4',
npm: {
devDependencies: {
'ember-source': '~3.4.0',
'@ember/test-helpers': '2.7.0',
'ember-decorators-polyfill': '^1.1.5',
},
},
},
{
name: 'ember-lts-3.8',
name: 'ember-lts-3.28',
npm: {
devDependencies: {
'ember-source': '~3.8.0',
'@ember/test-helpers': '2.7.0',
'ember-decorators-polyfill': '^1.1.5',
'ember-source': '~3.28.0',
},
},
},
{
name: 'ember-lts-3.12',
name: 'ember-lts-4.4',
npm: {
devDependencies: {
'ember-source': '~3.12.0',
'@ember/test-helpers': '2.7.0',
'ember-source': '~4.4.0',
},
},
},
{
name: 'ember-lts-3.28',
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({
'jquery-integration': false,
}),
},
name: 'ember-lts-4.8',
npm: {
devDependencies: {
'ember-source': '~3.28.0',
'ember-source': '~4.8.0',
},
},
},
Expand Down
1 change: 1 addition & 0 deletions tests/dummy/config/optional-features.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"application-template-wrapper": false,
"default-async-observers": true,
"jquery-integration": false,
"template-only-glimmer-components": true
}

0 comments on commit ba20c5b

Please sign in to comment.