Skip to content

Commit

Permalink
breaking(node support): drop support for node 12 and node 14
Browse files Browse the repository at this point in the history
  • Loading branch information
BlueCutOfficial committed Feb 2, 2024
1 parent 39342f2 commit 54ac991
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 16.x
cache: pnpm
- name: Install Dependencies
run: pnpm install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12
node-version: 16
registry-url: 'https://registry.npmjs.org'

- run: npm publish
Expand Down
4 changes: 1 addition & 3 deletions DEPRECATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ export class ApplicationController extends Controller {
-- [Replacing Component Helper.md](https://github.com/embroider-build/embroider/blob/main/docs/replacing-component-helper.md#when-youre-invoking-a-component-youve-been-given)

## Ember < 3.28 & node < 16 support
## Ember < 3.28

The v2 addon will no longer support Ember versions lower than 3.28.

Additionally, it will have dependencies such as `[email protected]` that require node 16, so node 12 and node 14 will be removed from the supported engines.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ The better way to handle modals in your Ember.js apps.

- Ember.js v3.4 or above
- Ember CLI v3.4 or above
- Node.js v12, v14 or above
- Node.js v16 or above

## Installation

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"webpack": "5.90.0"
},
"engines": {
"node": "12.* || 14.* || >= 16.*"
"node": ">= 16.*"
},
"changelog": {
"repo": "mainmatter/ember-promise-modals",
Expand Down

0 comments on commit 54ac991

Please sign in to comment.