Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update superagent npm dependency #302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

backflip
Copy link

@backflip backflip commented Jul 1, 2022

Description

The superagent dependency used (as well as its formidable dependency) is deprecated, leading to warnings on every npm install using @mailchimp/mailchimp_marketing.

Judging from https://github.com/visionmedia/superagent#upgrading-from-previous-versions, there should be no breaking changes and my own tests consuming @mailchimp/mailchimp_marketing are still running fine.

Known Issues

I'm unable to run npm run generate on my machine, it exits with the following error:

[main] ERROR io.swagger.codegen.DefaultGenerator - Could not process model 'inline_response_200_14'. Please make sure that your schema is correct!
java.lang.NullPointerException: Cannot read field "isContainer" because "cp" is null

This might be related to using [email protected] due to v2 not being installable on my ARM Apple.

@cla-bot
Copy link

cla-bot bot commented Jul 1, 2022

Contributor License Agreement Instructions
Thanks for your pull request. Before we can review your work, you’ll need to sign a Contributor License Agreement (CLA).

Please download the appropriate CLA below. Once downloaded, please read, sign, and send back to us at [email protected]. Please note, this account is not monitored so please visit https://mailchimp.com/contact/ if you need support.

Individual CLA: Mailchimp Individual CLA
Corporate CLA: Mailchimp Corporate CLA

Once you’ve emailed us the signed CLA, please reply here (e.g. CLA signed and sent!) and we’ll verify it.

What to do if you already signed the CLA
Individual signers
• If you’ve previously sent us a signed CLA, please reply here letting us know and we’ll verify. If we are unable to verify, It’s possible we don’t have your GitHub username or you’re using a different email address on your Git commit. Check that the CLA you previously submitted was sent to us using the email address associated with your GitHub username and verify that your email is set on your Git commits.
Corporate signers
• Your company has a Point of Contact (POC) who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you’ve previously sent us an updated CLA, please reply here letting us know and we’ll verify.
• The email used to register you as an authorized contributor must be the email used for the Git commit.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

@backflip
Copy link
Author

backflip commented Jul 1, 2022 via email

@nbouvrette
Copy link

@mc-keith @shogren could someone take a look at this issue? superagent is now at version 8.0.9

@Stanzilla
Copy link
Contributor

@shogren please take a look

@Stanzilla Stanzilla mentioned this pull request Sep 20, 2023
@emmekappa
Copy link

please merge this

@TanjaBayer
Copy link

This is open now 2 years. Please merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants