-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update superagent
#337
Update superagent
#337
Conversation
Contributor License Agreement Instructions Please download the appropriate CLA below. Once downloaded, please read, sign, and send back to us at [email protected]. Please note, this account is not monitored so please visit https://mailchimp.com/contact/ if you need support. Individual CLA: Mailchimp Individual CLA Once you’ve emailed us the signed CLA, please reply here (e.g. CLA signed and sent!) and we’ll verify it. What to do if you already signed the CLA |
CLA signed and sent! |
b8e9799
to
bdc9f8a
Compare
Contributor License Agreement Instructions Please download the appropriate CLA below. Once downloaded, please read, sign, and send back to us at [email protected]. Please note, this account is not monitored so please visit https://mailchimp.com/contact/ if you need support. Individual CLA: Mailchimp Individual CLA Once you’ve emailed us the signed CLA, please reply here (e.g. CLA signed and sent!) and we’ll verify it. What to do if you already signed the CLA |
CLA signed and sent! |
any news on this? |
is it possible to merge this? Thanks |
i would love to see this patch released too. 🙏 if there's anything anyone external can do to help push this PR forward, just say the word. ❤️ |
Seems mailchimp has stopped supporting their node package which is a real shame as it appears to still work ok for me. Is there a fork anywhere to get updated dependencies? |
@webkod3r |
Would love to see this merged so we stop getting this log message every time we use it.
|
can this be merged please so i stop seeing below (node:3) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. |
Continuation of #302
Description
The superagent dependency used (as well as its formidable dependency) is deprecated, leading to warnings on every npm install using @mailchimp/mailchimp_marketing.
Judging from visionmedia/superagent#upgrading-from-previous-versions, there should be no breaking changes and my own tests consuming @mailchimp/mailchimp_marketing are still running fine.
Known Issues
None