Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance error message/code and apply black formatter #19

Merged
merged 2 commits into from
Nov 8, 2023
Merged

feat: enhance error message/code and apply black formatter #19

merged 2 commits into from
Nov 8, 2023

Conversation

nasbench
Copy link
Member

@nasbench nasbench commented Nov 8, 2023

This PR adds the following:

  • Apply python black formatter to the code for more unified readability
  • Change error response code to 400 for both Sigma and Yaml errors.

This also fixes issue #17

@nasbench nasbench requested review from M3NIX and josehelps November 8, 2023 00:17
M3NIX
M3NIX approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@M3NIX M3NIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@M3NIX M3NIX merged commit 9a74093 into magicsword-io:main Nov 8, 2023
1 check passed
@M3NIX M3NIX linked an issue Nov 8, 2023 that may be closed by this pull request
API Documentation? #17
Closed
@M3NIX M3NIX mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M3NIX M3NIX M3NIX approved these changes

@josehelps josehelps Awaiting requested review from josehelps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Documentation?
2 participants
@nasbench @M3NIX