Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Documentation? #17

Closed
coreyogburn opened this issue Nov 2, 2023 · 2 comments · Fixed by #19
Closed

API Documentation? #17

coreyogburn opened this issue Nov 2, 2023 · 2 comments · Fixed by #19
Assignees
Labels
enhancement New feature or request

Comments

@coreyogburn
Copy link

I just ran into an issue where I unknowingly passed in bad yaml but got a 200 response back with an error message in the body. Is there documentation around this behavior? Is it enough to check if the response starts with Error: to determine if the request was actually successful or not?

@nasbench
Copy link
Member

nasbench commented Nov 2, 2023

Hi @coreyogburn

There isn't documentation around this. But yes, its enough to check for the keyword Error: to find conversion type errors (even if the code is 200). You can see the implementation here https://github.com/magicsword-io/sigconverter.io/blob/main/run.py#L63-L64

We will enhance the error handling to return appropriate error codes soon. For example 400 when a bad yaml is provided, etc.

Thanks for raising this issue.

@nasbench nasbench self-assigned this Nov 2, 2023
@nasbench nasbench added the enhancement New feature or request label Nov 2, 2023
@M3NIX M3NIX linked a pull request Nov 8, 2023 that will close this issue
@M3NIX
Copy link
Collaborator

M3NIX commented Nov 8, 2023

fixed with #19

@M3NIX M3NIX closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants