Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Move TT outside of Engine: independent class, instantiated at top level #1150

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Nov 4, 2024

PR discarded due to non-deterministic bench bug (#1182, #1181), new branch and PR will be created


73c5abe

Non-deterministic bench error though, probably related to passing around a class with a pinned object.
That is, when executing the binary with "bench" argument, results (node count) aren't always the same

Test  | refactor/tt-outside-of-engine-2-class-wrapper
Elo   | 3.95 +- 7.33 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | 1.23 (-2.25, 2.89) [-5.00, 0.00]
Games | 3344: +927 -889 =1528
Penta | [67, 356, 792, 386, 71]
https://openbench.lynx-chess.com/test/908/

@eduherminio eduherminio force-pushed the refactor/tt-outside-of-engine-2-class-wrapper branch from 6d521fc to 2add9fb Compare November 9, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant