Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Move TT outside of Engine: class wrapper #1184

Merged

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Nov 19, 2024

New version of #1150 after solving #1181, #1182 bug.

Same concept as #1185 (without wrapper), vs the static approach (#1149)

vs main

Test  | refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
Elo   | -2.37 +- 2.72 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.33 (-2.25, 2.89) [-3.00, 1.00]
Games | 26714: +7273 -7455 =11986
Penta | [658, 3198, 5764, 3142, 595]
https://openbench.lynx-chess.com/test/960/

vs main Workstation GC mode

Test  | refactor/tt-outside-of-engine-2-class-wrapper-with-bugfix
Elo   | -2.29 +- 2.70 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.26 (-2.25, 2.89) [-3.00, 1.00]
Games | 27172: +7478 -7657 =12037
Penta | [644, 3318, 5820, 3181, 623]
https://openbench.lynx-chess.com/test/959/

vs refactor/tm-outside-of-engine

Test  | refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
Elo   | -1.92 +- 2.38 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.25 (-2.25, 2.89) [-3.00, 1.00]
Games | 35130: +9642 -9836 =15652
Penta | [877, 4138, 7686, 4030, 834]
https://openbench.lynx-chess.com/test/961/
Test  | refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
Elo   | -1.88 +- 1.48 (95%)
SPRT  | 40.0+0.40s Threads=1 Hash=128MB
LLR   | -2.26 (-2.25, 2.89) [-5.00, 0.00]
Games | 69098: +17519 -17893 =33686
Penta | [954, 7739, 17465, 7509, 882]
https://openbench.lynx-chess.com/test/962/

@eduherminio eduherminio changed the base branch from main to refactor/tm-outside-of-engine November 19, 2024 23:41
Base automatically changed from refactor/tm-outside-of-engine to main November 20, 2024 17:54
@eduherminio eduherminio marked this pull request as ready for review November 26, 2024 10:18
@eduherminio
Copy link
Member Author

Merging despite the elo change, need a wrapper anyway,
Might follow-up with #1200

@eduherminio eduherminio merged commit 741768f into main Nov 26, 2024
27 checks passed
@eduherminio eduherminio deleted the refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix branch November 26, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant