-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Move TT outside of Engine: class wrapper #1184
Merged
eduherminio
merged 20 commits into
main
from
refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
Nov 26, 2024
Merged
🧹 Move TT outside of Engine: class wrapper #1184
eduherminio
merged 20 commits into
main
from
refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntiated at top level
…-of-engine-2-class-wrapper
…f-engine-2-class-wrapper
eduherminio
changed the base branch from
main
to
refactor/tm-outside-of-engine
November 19, 2024 23:41
…-of-engine-2-class-wrapper-after-bugfix
…f-engine-2-class-wrapper-after-bugfix
Merging despite the elo change, need a wrapper anyway, |
eduherminio
deleted the
refactor/tt-outside-of-engine-2-class-wrapper-after-bugfix
branch
November 26, 2024 10:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #1150 after solving #1181, #1182 bug.
Same concept as #1185 (without wrapper), vs the static approach (#1149)
vs main
vs main Workstation GC mode
vs refactor/tm-outside-of-engine