Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validator #101

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove validator #101

merged 1 commit into from
Sep 17, 2024

Conversation

mbasaglia
Copy link
Member

It's going to be moved to the main site

@mbasaglia mbasaglia added this to the 1.0 milestone Sep 17, 2024
Copy link
Member

@Aidosmf Aidosmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove:

  1. tools/validate.js?
  2. schema-validate.py?
  3. .github/workflows/test-animation?
  4. validate mentioned at "docs/editing/schema.md"?

@mbasaglia
Copy link
Member Author

None of them refer to the smart Lottie validator:

  1. tools/validate.js?

This is the script that validates the test files from the raw schema, doesn't use the validator

  1. schema-validate.py?

This checks the schema itself

  1. .github/workflows/test-animation?

This uses validate.js above, not the new validator

  1. validate mentioned at "docs/editing/schema.md"?

This mentions the schema-validate script

@b-wils
Copy link
Contributor

b-wils commented Sep 17, 2024

Changes look good, going to wait until this is on the main site to approve.

@b-wils b-wils marked this pull request as ready for review September 17, 2024 15:54
@b-wils b-wils merged commit 7b2baab into main Sep 17, 2024
6 checks passed
b-wils pushed a commit to b-wils/lottie-spec that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants