feat: lottie validator #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Aidosmf
commented
Sep 18, 2024
•
Aidosmf
commented
- moved lottie-validator logic from lottie-spec Remove validator lottie-spec#101
- adjusted & improved UI for responsiveness and similar styles
- issue: Move validator lottie-spec#93
Aidosmf
force-pushed
the
mf/validator
branch
from
632f665 to
e7883b0
Compare
Aidosmf
commented
Sep 18, 2024
There was a problem hiding this comment.
planning to create LottieValidator NPM package in Q4
There was a problem hiding this comment.
it's Glax's code without changes (only JS warnings were fixed)
Aidosmf
commented
Sep 18, 2024
There was a problem hiding this comment.
the schema will be moved to the LottieValidator NPM package
There was a problem hiding this comment.
We'll probably want to use versioned names for the schema file once we have a separate package
mbasaglia
approved these changes
Sep 23, 2024
|
Belated LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.