Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: OCPP 1.6j security extension #266

Merged

Conversation

xBlaz3kx
Copy link
Contributor

@xBlaz3kx xBlaz3kx commented Apr 1, 2024

Proposed changes

  • Implemented OCPP 1.6 security extension messages
  • Added implementation examples
  • Added tests for extension implementation

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

  • Code isn't unit tested

@xBlaz3kx xBlaz3kx mentioned this pull request Apr 1, 2024
9 tasks
@xBlaz3kx
Copy link
Contributor Author

xBlaz3kx commented Apr 1, 2024

@lorenzodonini requesting review, as per issue #262.

xBlaz3kx and others added 4 commits July 19, 2024 16:44
….1 dependencies in 1.6 package for the security extensions as some constants have different names. Also ensuring that the 1.6 validator validates the messages.
@xBlaz3kx
Copy link
Contributor Author

xBlaz3kx commented Aug 1, 2024

Hey @lorenzodonini, I'm working on tests for the extension. Will you be able to review it and let me know your thoughts regarding this PR?

@xBlaz3kx xBlaz3kx changed the title Implemented OCPP 1.6j security extension Feature: OCPP 1.6j security extension Aug 1, 2024
@AhmedAbouelkher
Copy link
Contributor

@lorenzodonini to be honest, I need this feature ASAP.
Is there a way that I can help to accelerate merging the security extension feature?

Copy link
Owner

@lorenzodonini lorenzodonini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to review this. Amazing work!

I went through the official whitepaper and verified all the types/fields. I left a few comments regarding some extra/missing fields (I presume the messages were copied from v2, but there are actually some differences). Please double-check.

Otherwise this is G2G, we can write more tests later on.

@AhmedAbouelkher
Copy link
Contributor

Hi @xBlaz3kx,
I've been working on fixes required by @lorenzodonini to speed things up.
Changes can be found in this PR: xBlaz3kx#1

* Added required fixes for PR lorenzodonini/ocpp-go/266

* revert `CertificateHashData` to be 40 chars long instead of 20
@xBlaz3kx
Copy link
Contributor Author

Hey @lorenzodonini @AhmedAbouelkher,

thank you for reviewing and catching all these details!
I guess I need to read the specification a bit better next time :)

I've merged @AhmedAbouelkher's PR to this branch and I think all of these issues were addressed.

I'll contribute the tests shortly, hopefully in a week or two.

@lorenzodonini
Copy link
Owner

Should I wait for the tests or merge this one right away? Test coverage drop is obviously expected, so don't mind the CI error

@xBlaz3kx
Copy link
Contributor Author

I think you should merge, since @AhmedAbouelkher needs it asap. I'll contribute/fix the tests in a separate PR.

@lorenzodonini lorenzodonini merged commit 41fd37d into lorenzodonini:master Sep 16, 2024
1 of 2 checks passed
@xBlaz3kx xBlaz3kx deleted the ocpp-1.6-security-extension branch September 16, 2024 20:09
@xBlaz3kx
Copy link
Contributor Author

xBlaz3kx commented Sep 16, 2024

@lorenzodonini Since this is a major update to the library, I think it would be best to create a new release 🎊

@lorenzodonini
Copy link
Owner

@lorenzodonini Since this is a major update to the library, I think it would be best to create a new release 🎊

There's a train of other small discussions/PRs I want to include. Will try to create a release in the next couple of days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants