-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: OCPP 1.6j security extension #266
Feature: OCPP 1.6j security extension #266
Conversation
@lorenzodonini requesting review, as per issue #262. |
….1 dependencies in 1.6 package for the security extensions as some constants have different names. Also ensuring that the 1.6 validator validates the messages.
…s well as the proper handling.
Hey @lorenzodonini, I'm working on tests for the extension. Will you be able to review it and let me know your thoughts regarding this PR? |
@lorenzodonini to be honest, I need this feature ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to review this. Amazing work!
I went through the official whitepaper and verified all the types/fields. I left a few comments regarding some extra/missing fields (I presume the messages were copied from v2, but there are actually some differences). Please double-check.
Otherwise this is G2G, we can write more tests later on.
Hi @xBlaz3kx, |
* Added required fixes for PR lorenzodonini/ocpp-go/266 * revert `CertificateHashData` to be 40 chars long instead of 20
Hey @lorenzodonini @AhmedAbouelkher, thank you for reviewing and catching all these details! I've merged @AhmedAbouelkher's PR to this branch and I think all of these issues were addressed. I'll contribute the tests shortly, hopefully in a week or two. |
Should I wait for the tests or merge this one right away? Test coverage drop is obviously expected, so don't mind the CI error |
I think you should merge, since @AhmedAbouelkher needs it asap. I'll contribute/fix the tests in a separate PR. |
@lorenzodonini Since this is a major update to the library, I think it would be best to create a new release 🎊 |
There's a train of other small discussions/PRs I want to include. Will try to create a release in the next couple of days |
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
Code isn't unit tested