Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OCPP 1.6 security extension #265

Closed
wants to merge 11 commits into from

Conversation

xBlaz3kx
Copy link
Contributor

Proposed changes

  • Implemented OCPP 1.6 security extension messages
  • Added implementation examples

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

  • Code isn't unit tested
  • Worked fine in staging/production environment

@dwibudut
Copy link
Contributor

dwibudut commented Mar 31, 2024

Hi @xBlaz3kx,

Why not use the standard specification for ISO15118 in ocpp1.6, as described in the following document:
https://openchargealliance.org/wp-content/uploads/2023/11/ocpp_1_6_ISO_15118_v10.pdf

@xBlaz3kx
Copy link
Contributor Author

Hey @dwibudut,

this is the OCPP 1.6 security extension, which includes certificate management feature (TLS/SSL for websockets certificate management as well as ISO 15118 certificate management) among other features.

I'm not sure what you're trying to say - have I implemented something wrong in regards to certificate management?

@dwibudut
Copy link
Contributor

dwibudut commented Apr 1, 2024

Hi @xBlaz3kx,

There isn't anything wrong. Actually, I'm a little confused about whether the document (version via DataTransfer) is for features: for example CertificateSigned, GetInstalledCertificateIds in document above is no longer valid or only for PnC

@xBlaz3kx
Copy link
Contributor Author

xBlaz3kx commented Apr 1, 2024

@dwibudut As I said before, this Security extension implementation has little to do with Plug and Charge feature implementation for OCPP 1.6. Here you can find any relevant information regarding this implementation.

Also, in the PnC specification, this note is applicable:

image

@xBlaz3kx
Copy link
Contributor Author

xBlaz3kx commented Apr 1, 2024

Moving to #266

@xBlaz3kx xBlaz3kx closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants