Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: waku improvements #384

Merged
merged 1 commit into from
Sep 13, 2023
Merged

feat: waku improvements #384

merged 1 commit into from
Sep 13, 2023

Conversation

agazso
Copy link
Contributor

@agazso agazso commented Sep 13, 2023

This PR contains multiple improvements that I found during testing with the bots:

  • Limit the number of messages in a chat to 100 (can be changed arbitrarily. This is needed because if the chat grows too long then the browser won't be able to load it and will use too much memory. Obviously this comes with old messages to be forgotten, maybe this could be added as an extra feature with a button to load historical messages on a per-demand basis.
  • Logs the console with debug loglevel if the waku is connected or not. This gives a nice visual feedback that helps evaluating intuitively the quality of the connection. Currently I see a disconnect in every 30 seconds (see this issue about it)
  • Insert the timestamp to subscribed messages too, instead of just filtered queried ones. This may potentially eliminate duplicated messages.

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku-objects-playground ✅ Ready (Inspect) Visit Preview Sep 13, 2023 1:43pm

@agazso agazso merged commit 1da964b into main Sep 13, 2023
2 checks passed
@agazso agazso deleted the feat/waku-improvements branch September 13, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants