-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterating on Github Action #135
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
b49b072
Iterating on Github Action
keepingitneil dec01f9
build docs
keepingitneil f56e034
remove steps for testing
keepingitneil 60f0b12
undo
keepingitneil ece1fe3
checkout with submodules
keepingitneil e1e2b61
livekit.rtc
keepingitneil 040b846
Try a venv
keepingitneil 580c641
venv
keepingitneil f20b832
debugging
keepingitneil 9a91e51
iterating
keepingitneil 47b49db
iterating
keepingitneil 63de4a0
iter
keepingitneil a50b38e
iter
keepingitneil fcecc2e
iter
keepingitneil 1b17281
iter
keepingitneil 6371f36
iter
keepingitneil 78b7d98
iter
keepingitneil 2dd6504
iter
keepingitneil 6a2231f
ffi
keepingitneil bef9686
trying
keepingitneil ea4b090
build wheel
keepingitneil d0ff2db
build wheel
keepingitneil 7ecd554
iter
keepingitneil a6430e8
iter
keepingitneil ead6542
iter
keepingitneil d3f75bc
iter
keepingitneil 75d0759
iter
keepingitneil 13ac800
iter
keepingitneil 0f47df1
iter
keepingitneil f040e78
iter
keepingitneil f2e2ab1
iter
keepingitneil 1ad304e
iter
keepingitneil d2ca9a1
iter
keepingitneil 24a504c
iter
keepingitneil f5e5f5b
iter
keepingitneil 5148117
iter
keepingitneil 3804542
iter
keepingitneil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,12 +9,24 @@ | |
name: Build Docs | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
package_dir: | ||
required: true | ||
type: string | ||
package_name: | ||
required: true | ||
type: string | ||
test: | ||
required: false | ||
type: boolean | ||
default: false | ||
workflow_call: | ||
inputs: | ||
package_dir: | ||
required: true | ||
type: string | ||
docs_entrypoint: | ||
package_name: | ||
required: true | ||
type: string | ||
secrets: | ||
|
@@ -34,36 +46,20 @@ jobs: | |
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Generate Egg Info | ||
run: python ${{ inputs.package_dir }}/setup.py egg_info | ||
|
||
- name: Find requires.txt | ||
run: | | ||
# Search for requirements.txt file and store its content in an environment variable | ||
REQUIREMENTS_FILE=$(find . -type f -name "requires.txt") | ||
echo "Found requires.txt file at: $REQUIREMENTS_FILE" | ||
if [ -n "$REQUIREMENTS_FILE" ]; then | ||
echo "REQUIREMENTS_FILE=$REQUIREMENTS_FILE" >> $GITHUB_ENV | ||
else | ||
echo "No requiress.txt file found." | ||
fi | ||
- name: Debug | ||
run: echo $REQUIREMENTS_FILE | ||
|
||
- name: Install Requirements From Egg Info | ||
run: python -m pip install -r $REQUIREMENTS_FILE | ||
with: | ||
submodules: recursive | ||
|
||
- name: Install Package to Document | ||
run: python -m pip install -e ${{ inputs.package_dir }} | ||
run: python -m pip install ${{ inputs.package_dir }}/ | ||
|
||
- name: Download ffi | ||
run: "[[ ${{ inputs.package_name }} = 'livekit.rtc' ]] && pip install requests && python livekit-rtc/rust-sdks/download_ffi.py --output $(python -m site --user-site)/livekit/rtc/resources" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only necessary for livekit-rtc There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can simplify this and move to build-rtc.yml |
||
|
||
- name: Install pdoc | ||
run: python -m pip install --upgrade pdoc | ||
run: pip install --upgrade pdoc | ||
|
||
- name: Build Docs | ||
run: python -m pdoc ${{ inputs.docs_entrypoint }} --docformat=google --output-dir docs | ||
run: python -m pdoc ${{ inputs.package_name }} --docformat=google --output-dir docs | ||
|
||
- name: S3 Upload | ||
run: aws s3 cp docs/ s3://livekit-docs/${{ inputs.package_dir }} --recursive | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need submodules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - pip install fails without it