Iterating on Github Action #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
reviewed
Jan 12, 2024
| - name: Install Requirements From Egg Info | ||
| run: python -m pip install -r $REQUIREMENTS_FILE | ||
| with: | ||
| submodules: recursive |
There was a problem hiding this comment.
Yeah - pip install fails without it
Where can I access the docs? Can you add a link to the README |
keepingitneil
force-pushed
the
neil/ga
branch
from
9ebfbd1 to
ece1fe3
Compare
Docs look like this: https://dhoiehpn9ahig.cloudfront.net/livekit-rtc/livekit/rtc.html (still need to figure out cloudfront to so docs.livekit.io redirects to these like the other ones) |
theomonnom
reviewed
Jan 15, 2024
| run: python -m pip install ${{ inputs.package_dir }}/ | ||
|
|
||
| - name: Download ffi | ||
| run: "[[ ${{ inputs.package_name }} = 'livekit.rtc' ]] && pip install requests && python livekit-rtc/rust-sdks/download_ffi.py --output $(python -m site --user-site)/livekit/rtc/resources" |
There was a problem hiding this comment.
Only necessary for livekit-rtc
There was a problem hiding this comment.
I think you can simplify this and move to build-rtc.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful run: https://github.com/livekit/python-sdks/actions/runs/7495215522/job/20404836012