Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8019] wagtail incremental upgrade from 4.1.6 to 5.2 #2554

Merged
merged 6 commits into from
Feb 22, 2024
Merged

[8019] wagtail incremental upgrade from 4.1.6 to 5.2 #2554

merged 6 commits into from
Feb 22, 2024

Conversation

m4ra
Copy link
Contributor

@m4ra m4ra commented Feb 8, 2024 •
edited
Loading

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@m4ra m4ra changed the title wagtail incrementalupgrade to 5.2 [8020] wagtail incremental upgrade from 4.1 to 5.2 Feb 8, 2024
@m4ra m4ra changed the title [8020] wagtail incremental upgrade from 4.1 to 5.2 [8020] wagtail incremental upgrade from 4.1.6 to 5.2 Feb 8, 2024
@m4ra m4ra changed the title [8020] wagtail incremental upgrade from 4.1.6 to 5.2 [8019] wagtail incremental upgrade from 4.1.6 to 5.0 Feb 8, 2024
@m4ra m4ra mentioned this pull request Feb 8, 2024
Merged
4 tasks
@goapunk goapunk self-requested a review February 12, 2024 13:55
goapunk
goapunk approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge (or add the update to 5.0 as in the PR title)

@m4ra
Copy link
Contributor Author

m4ra commented Feb 12, 2024

@goapunk I will continue till 5.0

@m4ra m4ra force-pushed the mk-2024-02-wagtail-upgrade-5.2 branch from c98fb09 to 0a90c28 Compare February 19, 2024 17:14
@m4ra m4ra changed the title [8019] wagtail incremental upgrade from 4.1.6 to 5.0 [8019] wagtail incremental upgrade from 4.1.6 to 5.2 Feb 19, 2024
@m4ra m4ra requested a review from goapunk February 19, 2024 17:48
@m4ra
Copy link
Contributor Author

m4ra commented Feb 22, 2024

I would like to merge this before continue on the django upgrade. So have a look when possible @goapunk

goapunk
goapunk reviewed Feb 22, 2024
View reviewed changes
requirements/base.txt Outdated Show resolved Hide resolved
goapunk
goapunk requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small note about the version

@m4ra m4ra force-pushed the mk-2024-02-wagtail-upgrade-5.2 branch from 48cfcd8 to 4ba7103 Compare February 22, 2024 13:07
@m4ra m4ra requested a review from goapunk February 22, 2024 13:07
goapunk
goapunk approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice!

@goapunk goapunk enabled auto-merge (rebase) February 22, 2024 13:12
@goapunk goapunk merged commit c5b600b into main Feb 22, 2024
2 checks passed
@goapunk goapunk deleted the mk-2024-02-wagtail-upgrade-5.2 branch February 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk goapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4ra @goapunk