-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7637] django upgrade to 4.2 #2552
Conversation
1cc15d5
to
7300abf
Compare
7300abf
to
35eb721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good, just one thing which I think is missing: the delete() -> form_valid() change was part of this update already
35eb721
to
294c980
Compare
fd2c1e8
to
a6f9f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! Only thing we need to take into account is that by updating the a4 hash we now have the ckeditor5 changes, so we can't release this until we did the ckeditor5 aplus story
@goapunk or we don't update the a4 hash. |
will it cause problems with a4 on django 3.2 and a+ on django 4.2 if we don't update the hash? |
@goapunk the topics might be an issue, though we don't use it in a+. Need to check if ckeditor was added after the multiselect-field. |
24e42f9
to
0fe1c33
Compare
50041ff
to
7239e86
Compare
7239e86
to
177e0ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we didn't do the deprecated app config bit but we can do them in a new PR and get this merged I'd say
To be merged after wagtail upgrade #2554
Tasks