Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lastHop parameter for loop in quotes #920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add lastHop parameter for loop in quotes #920

wants to merge 1 commit into from

Conversation

itsrachelfish
Copy link
Contributor

@itsrachelfish itsrachelfish commented Dec 13, 2024 •
edited
Loading

Fixes #904

Was able to reproduce this bug on regtest by changing the fee rate on one of my test nodes.

Screenshot from 2024-12-12 16-17-17

Fix was pretty simple because the swapView and loop protobuf definitons already had all of the necessary variables and functions defined 🎉

Screenshot from 2024-12-12 17-07-12

ViktorTigerstrom
ViktorTigerstrom approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could be worth getting an ACK from someone that works with the LiT frontend code as well :)

@guggero guggero requested a review from jamaljsr December 17, 2024 10:40
@jamaljsr jamaljsr requested a review from jbrill December 19, 2024 07:40
@jamaljsr
Copy link
Member

The code LGTM but haven't tested. Tagging @jbrill for review since I am OOO this week.

@lightninglabs-deploy
Copy link

@jamaljsr: review reminder
@jbrill: review reminder

jamaljsr
jamaljsr approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@jamaljsr jamaljsr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 👌

Just needs a rebase then can be merged.

@itsrachelfish
Copy link
Contributor Author

itsrachelfish commented Jan 6, 2025 •
edited
Loading

@jamaljsr Rebased and updated my release notes to use the new v0.14.1 file

@levmi levmi mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorTigerstrom ViktorTigerstrom ViktorTigerstrom approved these changes

@jamaljsr jamaljsr jamaljsr approved these changes

@jbrill jbrill Awaiting requested review from jbrill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loop-in: quote does not use last hop pubkey
4 participants
@itsrachelfish @jamaljsr @lightninglabs-deploy @ViktorTigerstrom