Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop-in: quote does not use last hop pubkey #904

Open
djkazic opened this issue Nov 18, 2024 · 1 comment · May be fixed by #920
Open

loop-in: quote does not use last hop pubkey #904

djkazic opened this issue Nov 18, 2024 · 1 comment · May be fixed by #920
Assignees
Labels
bug Something isn't working

Comments

@djkazic
Copy link
Contributor

djkazic commented Nov 18, 2024

Expected behavior / Actual behavior
A loop cli quote for my WOS loop in of 350k sat @ 6 conf_target is giving 177 sats for service fee, while terminal is giving 5 sats. Looks like the discrepancy is that last hop pubkey isn't being set for the quote, which in turn means the subsequent loopIn will likely fail if that node is more expensive than a quote that doesn't specify a node to loop in to.

Here we would want to use loopInLastHop:

const inQuote = await this._store.api.loop.getLoopInQuote(
amount,
this.confTarget,

Also would want a new param here for passing in that hop if it's specified:

async getLoopInQuote(

@djkazic djkazic added the bug Something isn't working label Nov 18, 2024
@itsrachelfish itsrachelfish linked a pull request Dec 13, 2024 that will close this issue
@levmi
Copy link
Contributor

levmi commented Jan 8, 2025

This ended up being just relevant for the litd binary UX. Has been fixed, will be merged shortly and included in next release. #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants