-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove opencv dependencies partial #1743
refactor: remove opencv dependencies partial #1743
Conversation
It looks like there is an error in unit tests, which is not shown while testing locally. |
@guarin, do you know what could be the reason? |
Not sure, would have to investigate. The error doesn't give a lot details. I restarted the run now to see if it is reproducible. |
@guarin, can I help somehow to resolve this? |
I am honestly not sure what the problem is and I sadly don't have time to reproduce it right now. At least in CI it is reproducible so there is something wrong. The only small thing I saw is that the Did you run your local tests with the same Python and Torchvision version as in CI? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1743 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 162 162
Lines 6729 6729
=======================================
Hits 5735 5735
Misses 994 994 ☔ View full report in Codecov by Sentry. |
@guarin, I've resolved the issue, please check. The problem was with video format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time and fixing this!
No description provided.