Removing Open CV dependencies #1679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partly fixes - #1477 |
guarin
requested changes
Oct 8, 2024
| for frame in frames: | ||
| out.write(frame) | ||
| out.release() | ||
| out = torchvision.io.write_video(path, self.frames_over_videos, frames) |
There was a problem hiding this comment.
Suggested change
| out = torchvision.io.write_video(path, self.frames_over_videos, frames) | |
| out = torchvision.io.write_video(filename=path, video_array=frames, fps=1) |
self.frames_over_videos is a list of videos and we want to save every video individually.
| for frame in self.frames: | ||
| out.write(frame) | ||
| out.release() | ||
| out = torchvision.io.write_video(path, self.frames, n_frames_per_video) |
There was a problem hiding this comment.
Suggested change
| out = torchvision.io.write_video(path, self.frames, n_frames_per_video) | |
| out = torchvision.io.write_video(filename=path, video_array=self.frames, fps=1) |
|
@guarin, is there a way I can help with completing this PR? |
|
Hi, yes that would be very helpful. You can merge the changes from this branch into your fork and make a new PR if that is ok? |
|
@guarin, sure. Are you online during weekends? |
|
I'm usually only available during weekdays |
|
This has been fixed in #1743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.