Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Amplitude Rescaling Transform #1694

Merged
merged 8 commits into from
Oct 21, 2024

Conversation

payo101
Copy link
Contributor

@payo101 payo101 commented Oct 12, 2024

Closes: #1658

Modified file(s)

  • lightly/transforms/__init__.py: Added new transform imports

Created file(s)

  • lightly/transforms/amplitude_rescale_transform.py
  • tests/transforms/test_amplitude_rescale_transform.py

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (5ac3898) to head (899bad8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
+ Coverage   84.86%   84.90%   +0.04%     
==========================================
  Files         155      156       +1     
  Lines        6508     6526      +18     
==========================================
+ Hits         5523     5541      +18     
  Misses        985      985              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SauravMaheshkar
Copy link
Collaborator

Could you please provide some input-output pairs?

@payo101
Copy link
Contributor Author

payo101 commented Oct 13, 2024

Sure, @SauravMaheshkar , give me some time on that

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Left some comments.

tests/transforms/test_amplitude_rescale_transform.py Outdated Show resolved Hide resolved
lightly/transforms/amplitude_rescale_transform.py Outdated Show resolved Hide resolved
lightly/transforms/amplitude_rescale_transform.py Outdated Show resolved Hide resolved
lightly/transforms/amplitude_rescale_transform.py Outdated Show resolved Hide resolved
lightly/transforms/amplitude_rescale_transform.py Outdated Show resolved Hide resolved
@guarin guarin mentioned this pull request Oct 14, 2024
@payo101
Copy link
Contributor Author

payo101 commented Oct 20, 2024

Hi @guarin , sorry being so late on this. I have made the requested changes. Please have a look

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@guarin guarin merged commit 9578268 into lightly-ai:master Oct 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants