-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhaseShift transform #1659
Comments
Hi, I am new to open source contributions, I would like to contribute to this one. Tell me if I am doing it right. |
Hi, thanks a lot for helping out! Let me know if you need any help :) |
Hi, if this issue is still open, I would like to work on it. Please assign it to me . |
@JanumalaAkhilendra you can take it if you want. I tried and didn't understand much. @guarin can you please assign him. |
I've assigned the issue to you @JanumalaAkhilendra, looking forward to the PR. |
@guarin Hi, I'd like to work on this issue, could you assign it to me also |
@pearguacamole, we only allow one assignment per issue; please have a look at the other available issues: good first issue |
Sure I'll look into other other available issues, do assign me this If it becomes available |
For context, you have to do pretty much the same thing as in #1694 but instead of changing the amplitude you have to modify the phase. |
@JanumalaAkhilendra did you already have time to look into this? |
@guarin it is taking more time than i expected to complete this, you can assign it to the next person |
@pearguacamole this issue would be free again if you are still interested in working on it. You can follow the structure from this PR #1694 but instead of modifying the amplitude you have to modify the phase. |
Yes, I'm interested in working on it, you can assign it to me. Thanks |
@guarin sorry for the delay, got some impromptu exams. So, I basically did the same thing as #1694 but added a step to decide if we are going to add or subtract theta while shifting the phase, as suggested by the paper. |
See #1646 for information
The text was updated successfully, but these errors were encountered: