Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PhaseShift transform #1659

Closed
Tracked by #1646
guarin opened this issue Oct 2, 2024 · 14 comments · Fixed by #1714
Closed
Tracked by #1646

Add PhaseShift transform #1659

guarin opened this issue Oct 2, 2024 · 14 comments · Fixed by #1714

Comments

@guarin
Copy link
Contributor

guarin commented Oct 2, 2024

See #1646 for information

@4ritam
Copy link

4ritam commented Oct 2, 2024

Hi, I am new to open source contributions, I would like to contribute to this one. Tell me if I am doing it right.

@guarin guarin assigned guarin and 4ritam and unassigned guarin Oct 2, 2024
@guarin
Copy link
Contributor Author

guarin commented Oct 2, 2024

Hi, thanks a lot for helping out! Let me know if you need any help :)

@JanumalaAkhilendra
Copy link

Hi, if this issue is still open, I would like to work on it. Please assign it to me .

@4ritam
Copy link

4ritam commented Oct 5, 2024

@JanumalaAkhilendra you can take it if you want. I tried and didn't understand much. @guarin can you please assign him.

@SauravMaheshkar
Copy link
Collaborator

Hi, if this issue is still open, I would like to work on it. Please assign it to me .

I've assigned the issue to you @JanumalaAkhilendra, looking forward to the PR.

@pearguacamole
Copy link
Contributor

@guarin Hi, I'd like to work on this issue, could you assign it to me also

@SauravMaheshkar
Copy link
Collaborator

@pearguacamole, we only allow one assignment per issue; please have a look at the other available issues: good first issue

@pearguacamole
Copy link
Contributor

Sure I'll look into other other available issues, do assign me this If it becomes available

@guarin
Copy link
Contributor Author

guarin commented Oct 14, 2024

For context, you have to do pretty much the same thing as in #1694 but instead of changing the amplitude you have to modify the phase.

@guarin
Copy link
Contributor Author

guarin commented Oct 21, 2024

@JanumalaAkhilendra did you already have time to look into this?

@JanumalaAkhilendra
Copy link

@guarin it is taking more time than i expected to complete this, you can assign it to the next person

@guarin
Copy link
Contributor Author

guarin commented Oct 21, 2024

@pearguacamole this issue would be free again if you are still interested in working on it. You can follow the structure from this PR #1694 but instead of modifying the amplitude you have to modify the phase.

@pearguacamole
Copy link
Contributor

Yes, I'm interested in working on it, you can assign it to me. Thanks

@pearguacamole
Copy link
Contributor

@guarin sorry for the delay, got some impromptu exams. So, I basically did the same thing as #1694 but added a step to decide if we are going to add or subtract theta while shifting the phase, as suggested by the paper.
Here I have used Bernoulli distribution of 0.5 to determine the sign of theta, as there was no indication of basis to decide the sign in the paper.
Please do suggest any changes you think should be made. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants