doc: switch from "leaky" to "token" bucket #1790
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two metaphors are mirrors of each other, and either works, but since we use the "token" bucket metaphor internally in Boulder, it's less confusing to use the same metaphor externally.
aarongable
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Saying "token bucket" is not only more consistent, it's more correct. Generally, a token bucket it full of tokens (surprise!), which are spent by requests and regenerate at a steady rate. In contrast, a leaky bucket is generally full of requests, which are allowed to "leak" out of the bucket (be processed) at a steady rate. Leaky buckets result in much steadier traffic flow, but requires a queuing mechanism to store the requests while they wait in the bucket.
ludekjanda
added a commit
that referenced
this pull request
Dec 13, 2024
# Latest from Crowdin - Updates in Danish, French, Hebrew, Hungarian, Korean, Russian, Ukrainian, Chinese (China) - Changes resulting from: - #1788 - #1790 - #1792 - #1794 Co-authored-by: Ludek Janda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two metaphors are mirrors of each other, and either works, but since we use the "token" bucket metaphor internally in Boulder, it's less confusing to use the same metaphor externally.