Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use grid for asset rows to stop overflow while allowing width, c… #4359

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: use grid for asset rows to stop overflow while allowing width, c… #4359

merged 1 commit into from
Oct 16, 2023

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Oct 16, 2023 •
edited
Loading

Try out this version of Leather — download extension builds.

This PR uses a Grid to contain the asset list items so that the title:

  • can use the full width available
  • will use ellipsis to truncate when needed

Here's a demo video:

Kapture.2023-10-16.at.11.39.22.mp4

Note In the video I have hardcoded the title to be "You won 2000STX=>www.stxwon.com" for demonstration purposes only. Putting it in line 54 of StacksFungibleTokenAssetItemLayout

@pete-watters pete-watters marked this pull request as ready for review October 16, 2023 10:42
@pete-watters pete-watters self-assigned this Oct 16, 2023
@pete-watters pete-watters linked an issue Oct 16, 2023 that may be closed by this pull request
Ensure full token names show if space available #4170
Closed
@pete-watters pete-watters mentioned this pull request Oct 16, 2023
Closed
kyranjamie
kyranjamie approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pete-watters pete-watters added this pull request to the merge queue Oct 16, 2023
Merged via the queue into dev with commit 529c03d Oct 16, 2023
26 checks passed
@pete-watters pete-watters deleted the fix/4170/ensure-full-token-space branch October 16, 2023 14:01
@pete-watters pete-watters mentioned this pull request Oct 16, 2023
Merged
@pete-watters pete-watters mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

@fbwoolf fbwoolf Awaiting requested review from fbwoolf

@alter-eggo alter-eggo Awaiting requested review from alter-eggo

Assignees

@pete-watters pete-watters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure full token names show if space available
2 participants
@pete-watters @kyranjamie