-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure full token names show if space available #4170
Comments
Pretty sure there was an issue at one point to address these long names? |
I think here we need to use ellipsis to truncate if we are in the extension view, but then in full screen view if there is space allow the full width to be used. We increased the minimum page width so there may be more space to show them there. We could also possibly add a tooltip in extension mode so if the name gets cut off you can hover and see it. @mica000 do you have any ideas on improving this? |
Would something like this work in all views? .class {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
} |
Yes, this is the expected behavior 🙌 |
For the row that is overlapping - this looks like a visual bug? Not sure exactly why this is happening. Any clarification possible to understand what's going on? Ideally the container is set to wrap around the row content so no scroll needed if there is space to grow. When there is no space to grow, then we show the scroll |
We'd need fluid width text truncation, guide here https://css-tricks.com/flexbox-truncated-text (some what tricky when not a fixed width). Anyone that jumps on this, use viewport width to establish whether to truncate (not |
Thanks Kyran, I can work on this to solve it |
I have opened a PR for this. I chose to use a grid instead of fluid width text truncation as it seems cleaner and a better fit here. |
This token is fraudulent so inadvertently it's good we cut it off, but in general we should show the entire token name if there's space (to the right) to show it on the home screen, such as here when in full tab mode:
The text was updated successfully, but these errors were encountered: