Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure full token names show if space available #4170

Closed
markmhendrickson opened this issue Sep 2, 2023 · 9 comments · Fixed by #4359 or #4363
Closed

Ensure full token names show if space available #4170

markmhendrickson opened this issue Sep 2, 2023 · 9 comments · Fixed by #4359 or #4363
Assignees
Labels
bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:small Expected to take up to 1 day of integration work

Comments

@markmhendrickson
Copy link
Collaborator

This token is fraudulent so inadvertently it's good we cut it off, but in general we should show the entire token name if there's space (to the right) to show it on the home screen, such as here when in full tab mode:

Image

@fbwoolf
Copy link
Contributor

fbwoolf commented Sep 2, 2023

I actually did this bc mine were going to multiple lines and causing issues in the UI...

Screen Shot 2023-05-31 at 4 28 07 PM

What else should we do here then?

@fbwoolf
Copy link
Contributor

fbwoolf commented Sep 2, 2023

Pretty sure there was an issue at one point to address these long names?

@pete-watters
Copy link
Contributor

I think here we need to use ellipsis to truncate if we are in the extension view, but then in full screen view if there is space allow the full width to be used.

We increased the minimum page width so there may be more space to show them there.

We could also possibly add a tooltip in extension mode so if the name gets cut off you can hover and see it.

@mica000 do you have any ideas on improving this?

@aryzing
Copy link

aryzing commented Sep 5, 2023

Would something like this work in all views?

.class {
  white-space: nowrap;
  overflow: hidden;
  text-overflow: ellipsis;
}

@mica000
Copy link

mica000 commented Sep 5, 2023

I think here we need to use ellipsis to truncate if we are in the extension view, but then in full screen view if there is space allow the full width to be used.

We increased the minimum page width so there may be more space to show them there.

We could also possibly add a tooltip in extension mode so if the name gets cut off you can hover and see it.

@mica000 do you have any ideas on improving this?

Yes, this is the expected behavior 🙌

@mica000
Copy link

mica000 commented Sep 5, 2023

I actually did this bc mine were going to multiple lines and causing issues in the UI...

Screen Shot 2023-05-31 at 4 28 07 PM

What else should we do here then?

For the row that is overlapping - this looks like a visual bug? Not sure exactly why this is happening. Any clarification possible to understand what's going on?

Ideally the container is set to wrap around the row content so no scroll needed if there is space to grow.

When there is no space to grow, then we show the scroll

@kyranjamie
Copy link
Collaborator

We'd need fluid width text truncation, guide here https://css-tricks.com/flexbox-truncated-text (some what tricky when not a fixed width).

Anyone that jumps on this, use viewport width to establish whether to truncate (not whenPageType()).

@pete-watters pete-watters self-assigned this Sep 11, 2023
@pete-watters
Copy link
Contributor

Thanks Kyran, I can work on this to solve it

@pete-watters pete-watters added effort:small Expected to take up to 1 day of integration work bug-p3 Non-critical functionality broken for many users, or there are clear workarounds labels Oct 16, 2023
@pete-watters
Copy link
Contributor

I have opened a PR for this. I chose to use a grid instead of fluid width text truncation as it seems cleaner and a better fit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:small Expected to take up to 1 day of integration work
Projects
None yet
6 participants