fix: script type unknown #4168
Merged
fix: script type unknown #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is here to test: https://github.com/leather-wallet/extension/actions/runs/6052120932 |
This was referenced Sep 1, 2023
alter-eggo
approved these changes
Sep 3, 2023
fbwoolf
force-pushed
the
fix/script-type-unknown
branch
2 times, most recently
from
db54855 to
304dc96
Compare
fbwoolf
force-pushed
the
fix/script-type-unknown
branch
from
304dc96 to
76b3cf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing this as a change to handle when the output script type is
unknown. It currently errors in btc-signer lib when we try to display the output address in the UI. Hiding the unknown outputs in the details view bc they are present in the viewable raw tx.