-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Use react-i18next instead of i18n #173 #195
Fix Use react-i18next instead of i18n #173 #195
Conversation
c79b2ea
to
00b4e64
Compare
ea37439
to
90f4cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check App.js file again. I understand that you wanted to fix padding on some of the blocks, but this introduced huge diff, which is hard to track what's happening there :\
be21be3
to
071c23c
Compare
071c23c
to
db64fcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than small changes and clarification for App.js file - looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SimpleBalance was lost in App.js as well.
Please, check with latest master that we won't lose any functionality that was brought to the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamonuwa, please, pick up latest master from leapdao/plasma-burner-wallet and double-check this file.
I've spotted several differences from master branch. For example:
<MoreButtons>
around line 852 lost expertMode proplet selected
is never used inside of the<Balance>
component- wrong spacing on
<Balance>
components - line 980 <Bity>
component on line 1056 lost props currencyDisplay and convertCurrency
I've stopped on that last piece - and it was only half the file - since there are too many changes that is troublesome to spot.
Am taking a look again |
@MaxStalker closing this in favor of #241 |
Fixes #173