Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Use react-i18next instead of i18n #173 #195

Closed

Conversation

iamonuwa
Copy link
Member

@iamonuwa iamonuwa commented Jul 8, 2019

Fixes #173

@iamonuwa iamonuwa force-pushed the fix/173-react-18next-interpolation branch from c79b2ea to 00b4e64 Compare July 8, 2019 18:06
@iamonuwa iamonuwa force-pushed the fix/173-react-18next-interpolation branch from ea37439 to 90f4cfe Compare July 17, 2019 10:48
@iamonuwa iamonuwa requested review from TimDaub and MaxStalker and removed request for TimDaub July 17, 2019 15:51
Copy link
Member

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check App.js file again. I understand that you wanted to fix padding on some of the blocks, but this introduced huge diff, which is hard to track what's happening there :\

src/components/Bity.js Outdated Show resolved Hide resolved
src/components/Bity.js Outdated Show resolved Hide resolved
src/components/SendToAddress.js Outdated Show resolved Hide resolved
src/components/WithdrawFromPrivate.js Outdated Show resolved Hide resolved
src/components/Receive.js Outdated Show resolved Hide resolved
src/components/Exchange.js Outdated Show resolved Hide resolved
src/components/Exchange.js Outdated Show resolved Hide resolved
src/components/Exchange.js Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/App.js Show resolved Hide resolved
@iamonuwa iamonuwa force-pushed the fix/173-react-18next-interpolation branch from be21be3 to 071c23c Compare July 19, 2019 08:42
@iamonuwa iamonuwa force-pushed the fix/173-react-18next-interpolation branch from 071c23c to db64fcf Compare July 19, 2019 08:47
Copy link
Member

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small changes and clarification for App.js file - looks good :)

src/App.js Outdated Show resolved Hide resolved
src/App.js Show resolved Hide resolved
src/App.js Show resolved Hide resolved
Copy link
Member

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SimpleBalance was lost in App.js as well.
Please, check with latest master that we won't lose any functionality that was brought to the project.

src/components/BurnWallet.js Outdated Show resolved Hide resolved
Copy link
Member

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamonuwa, please, pick up latest master from leapdao/plasma-burner-wallet and double-check this file.
I've spotted several differences from master branch. For example:

  • <MoreButtons> around line 852 lost expertMode prop
  • let selected is never used inside of the <Balance> component
  • wrong spacing on <Balance> components - line 980
  • <Bity> component on line 1056 lost props currencyDisplay and convertCurrency

I've stopped on that last piece - and it was only half the file - since there are too many changes that is troublesome to spot.

@iamonuwa
Copy link
Member Author

Am taking a look again

@iamonuwa
Copy link
Member Author

iamonuwa commented Aug 3, 2019

@MaxStalker closing this in favor of #241

@iamonuwa iamonuwa closed this Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use react-i18next instead of i18n
2 participants