Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

fix commas and periods in amount field upstream #47

Closed
johannbarbie opened this issue Aug 2, 2019 · 5 comments · Fixed by leapdao/plasma-burner-wallet#241
Closed

fix commas and periods in amount field upstream #47

johannbarbie opened this issue Aug 2, 2019 · 5 comments · Fixed by leapdao/plasma-burner-wallet#241
Labels
bounty bug Something isn't working Payout requested size-S 350 SDP

Comments

@johannbarbie
Copy link
Collaborator

No description provided.

@TimDaub TimDaub changed the title fix commas and periods in amount field fix commas and periods in amount field upstream Aug 2, 2019
@TimDaub TimDaub added bug Something isn't working bounty labels Aug 2, 2019
@TimDaub
Copy link
Member

TimDaub commented Aug 2, 2019

Scope

  • Currently, the burner wallet uses the i18n package to do localization
  • We're about to use react-i18next: Fix Use react-i18next instead of i18n #173 leapdao/plasma-burner-wallet#195
  • Try the following on your burner-wallet:
    • Depending on your browser language, try sending an amount of money with decimals but alternate between a period . and a comma ,. So in the SendToAddress.js view try putting into the <Input /> 2.5 or 2,5.
  • You'll notice that often decimal values but particular their delimiter (so commas or periods) will bug the process

Deliverables

  • Fix this issue upstream (leapdao/plasma-burner-wallet)
  • Then create a PR to fix this issue also in this repo
  • Make sure that you test various languages that prefer commas over periods and vice versa

Note

It might make sense to get in contact with @MaxStalker and/or @iamonuwa as they've already done some work on this topic and might know more!

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

@iamonuwa
Copy link

iamonuwa commented Aug 3, 2019

I would love to work on this. As I already implemented it on burner. I'll rebase both

@TimDaub
Copy link
Member

TimDaub commented Aug 19, 2019

@iamonuwa I unassigned you from here as I remember you mentioned that you won't do it, correct?

@iamonuwa
Copy link

Right

@TimDaub
Copy link
Member

TimDaub commented Aug 22, 2019

Fixed in #118

@TimDaub TimDaub closed this as completed Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bounty bug Something isn't working Payout requested size-S 350 SDP
Projects
None yet
3 participants