Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Leaderboard Endpoint #232

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Get Leaderboard Endpoint #232

merged 11 commits into from
Sep 9, 2024

Conversation

zysim
Copy link
Collaborator

@zysim zysim commented Aug 18, 2024 •
edited
Loading

Closes #228

@zysim zysim requested a review from a team as a code owner August 18, 2024 04:22
@zysim zysim marked this pull request as draft August 18, 2024 04:22
@zysim zysim self-assigned this Aug 18, 2024
@zysim zysim force-pushed the getLeaderboardById branch 2 times, most recently from 39de7c4 to c796aee Compare August 18, 2024 04:38
@zysim zysim marked this pull request as ready for review August 18, 2024 04:38
@zysim zysim force-pushed the getLeaderboardById branch from c796aee to f681017 Compare August 18, 2024 04:59
@zysim zysim force-pushed the getLeaderboardById branch from 43de5cb to 3223dde Compare September 5, 2024 17:36
@zysim zysim requested a review from TheTedder September 5, 2024 17:36
@zysim zysim requested a review from TheTedder September 7, 2024 06:11
TheTedder
TheTedder reviewed Sep 7, 2024
View reviewed changes
Copy link
Contributor

@TheTedder TheTedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff. I didn't have much time today so it's not a super thorough review. I'll potentially add more comments if I think of them later.

LeaderboardBackend.Test/Leaderboards.cs Outdated Show resolved Hide resolved
LeaderboardBackend/Controllers/LeaderboardsController.cs Outdated Show resolved Hide resolved
LeaderboardBackend/Services/Impl/LeaderboardService.cs Outdated Show resolved Hide resolved
@zysim zysim force-pushed the getLeaderboardById branch from 2c53611 to 7d1ea1d Compare September 9, 2024 13:51
@zysim zysim force-pushed the getLeaderboardById branch from 7d1ea1d to 016c12f Compare September 9, 2024 14:43
@zysim zysim merged commit 4c5bedf into leaderboardsgg:main Sep 9, 2024
1 check passed
@zysim zysim deleted the getLeaderboardById branch September 9, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheTedder TheTedder TheTedder approved these changes

Assignees

@zysim zysim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Leaderboard Endpoint
2 participants
@zysim @TheTedder