Get leaderboard endpoint

leaderboardsgg · Aug 18, 2024 · f681017 · f681017
1 parent b08efce
commit f681017
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/LeaderboardBackend/Controllers/LeaderboardsController.cs b/LeaderboardBackend/Controllers/LeaderboardsController.cs
@@ -13,13 +13,11 @@ public class LeaderboardsController : ApiController
 {
     private readonly ILeaderboardService _leaderboardService;
 
-    public LeaderboardsController(ILeaderboardService leaderboardService)
-    {
+    public LeaderboardsController(ILeaderboardService leaderboardService) =>
         _leaderboardService = leaderboardService;
-    }
 
     [AllowAnonymous]
-    [HttpGet("{id:long}")]
+    [HttpGet("/api/leaderboard/{id:long}")]
     [SwaggerOperation("Gets a leaderboard by its ID.")]
     [SwaggerResponse(200)]
     [SwaggerResponse(404)]

diff --git a/LeaderboardBackend/Services/Impl/LeaderboardService.cs b/LeaderboardBackend/Services/Impl/LeaderboardService.cs
@@ -12,17 +12,14 @@ public LeaderboardService(ApplicationContext applicationContext)
         _applicationContext = applicationContext;
     }
 
-    public async Task<Leaderboard?> GetLeaderboard(long id)
-    {
-        return await _applicationContext.Leaderboards.FindAsync(id);
-    }
+    public async Task<Leaderboard?> GetLeaderboard(long id) =>
+        await _applicationContext.Leaderboards
+            .FirstOrDefaultAsync(board => board.Id == id);
 
-    public Task<Leaderboard?> GetLeaderboardBySlug(string slug)
-    {
-        return _applicationContext.Leaderboards
+    public Task<Leaderboard?> GetLeaderboardBySlug(string slug) =>
+        _applicationContext.Leaderboards
             .AsNoTracking()
             .FirstOrDefaultAsync(x => x.Slug == slug);
-    }
 
     // FIXME: Paginate this
     public async Task<List<Leaderboard>> GetLeaderboards(long[]? ids = null)

diff --git a/LeaderboardBackend/openapi.json b/LeaderboardBackend/openapi.json
@@ -453,7 +453,7 @@
         }
       }
     },
-    "/api/Leaderboards/{id}": {
+    "/api/leaderboard/{id}": {
       "get": {
         "tags": [
           "Leaderboards"