Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly rework mu-task handling #307

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Dec 10, 2024

Overview

This PR includes two internal changes:

  • Usage of more generic task 'status' URIs
  • Use ember-data + mu-cl-resources to fetch tasks using JSON:API
connected issues and PRs:

lblod/reglement-publish-service#19
lblod/app-reglementaire-bijlage#88

Setup

Check-out lblod/app-reglementaire-bijlage#88 for instructions

How to test/reproduce

Check-out lblod/app-reglementaire-bijlage#88 for instructions

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma force-pushed the internal/task-rework branch from a79424b to bc5cbba Compare December 13, 2024 14:39
@elpoelma elpoelma marked this pull request as ready for review December 13, 2024 14:40
Copy link
Contributor

@piemonkey piemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one very minor comment.

@@ -0,0 +1,6 @@
import Model, { attr } from '@ember-data/model';

export default class TaskModel extends Model {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, should this also have the type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Version bumps, chores, tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants