Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mu-tasks #88

Draft
wants to merge 2 commits into
base: mu-auth-config-improvements
Choose a base branch
from

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Dec 10, 2024

Overview

This PR includes two changes related to mu-tasks:

  • A migration which moves their status-URIs to a more generic domain
  • Support for tasks, jobs and job-errors in mu-cl-resources and mu-auth
connected issues and PRs:

lblod/frontend-reglementaire-bijlage#307
lblod/reglement-publish-service#19

Setup

Requires both:

Include lblod/reglement-publish-service#19 in your stack:

publisher:
  image: !reset null
  build: https://github.com/lblod/reglement-publish-service.git#internal/adjust-task-status-uris

How to test/reproduce

  • Start both the stack and frontend
  • Open/create a template and ensure you are able to publish it
  • Ensure you can access the published template in GN

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@elpoelma elpoelma changed the base branch from master to mu-auth-config-improvements December 13, 2024 14:43
@elpoelma elpoelma force-pushed the internal/update-tasks-model branch from 348cb89 to a751b64 Compare December 13, 2024 14:44
@elpoelma elpoelma force-pushed the internal/update-tasks-model branch from a751b64 to ce1cb3b Compare December 13, 2024 14:58
@elpoelma elpoelma self-assigned this Dec 13, 2024
Copy link
Contributor

@piemonkey piemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants