-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utility functions to draw shapes that visualise tensors and vectors #289
Conversation
@rosecers I think I addressed all your comments. Nod if you're OK with merging now so we can move on to the next PR! |
Regarding arrows: should we have these as predefined shape type inside chemiscope? This will save a lot of space by not requiring to store all the vertices/simplices in the file, but instead generate them on the JS side like we do for ellispoids. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like @Luthaf's suggestion of an arrow as, essentially, a primitive type!
I agree, but I would like to do this as part of a separate PR in which we address the input format too. In the spirit of doing small incremental PRs. |
This allows to visualize vectorial and tensorial properties for each atom.
b27dccb
to
59742e5
Compare
This is tracked in #291! |
Added utility functions to visualize positive-definite tensors (polarizability, thermal ellipsoids, ...) as well as vectors (forces, dipoles, ....). The latter required changing (switching off) the centering of the shapes. I think this is better, because you can always center (and add a utility function for that) a custom shape, but you can't draw an off-center shape if vertices get centered automatically.
Also fixed
chemiscope.show
so it takes ashapes
argument.