Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrows as predefined shape type on the JS side #291

Closed
Luthaf opened this issue Aug 29, 2023 · 1 comment
Closed

Add arrows as predefined shape type on the JS side #291

Luthaf opened this issue Aug 29, 2023 · 1 comment
Labels
component-structure Issues related to the structure viewer component

Comments

@Luthaf
Copy link
Contributor

Luthaf commented Aug 29, 2023

Regarding arrows: should we have these as predefined shape type inside chemiscope? This will save a lot of space by not requiring to store all the vertices/simplices in the file, but instead generate them on the JS side like we do for ellispoids.

Originally posted by @Luthaf in #289 (comment)

@Luthaf Luthaf added the component-structure Issues related to the structure viewer component label Aug 29, 2023
@ceriottm
Copy link
Contributor

ceriottm commented Oct 5, 2023

Fixed in #292

@ceriottm ceriottm closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-structure Issues related to the structure viewer component
Projects
None yet
Development

No branches or pull requests

2 participants