Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY #1289

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Oct 7, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

TBD

@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Oct 7, 2024
@kubevirt-bot kubevirt-bot requested review from ormergi and qinqon October 7, 2024 08:43
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Feature		Default	Stage	Since	Until
---------------------------------------------
CPUManager	false	Alpha	1.8	1.9
CPUManager	true	Beta	1.10	1.25
CPUManager	true	GA	1.26	–

https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features

Signed-off-by: Lee Yarwood <[email protected]>
@lyarwood lyarwood force-pushed the remove-kubevirt-cpu-manager-policy branch from 1c23f2a to fb2a713 Compare November 18, 2024 10:09
@lyarwood lyarwood marked this pull request as ready for review November 18, 2024 10:09
@lyarwood lyarwood changed the title WIP k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY Nov 18, 2024
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@dosubot dosubot bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 18, 2024
@kubevirt-bot
Copy link
Contributor

@lyarwood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-gocli fb2a713 link true /test check-gocli
check-provision-k8s-1.29 fb2a713 link true /test check-provision-k8s-1.29
check-provision-k8s-1.31-s390x fb2a713 link true /test check-provision-k8s-1.31-s390x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants