Skip to content

Commit

Permalink
cluster-up,cluster-provision: Remove the now GA'd CPUManager FG
Browse files Browse the repository at this point in the history
Feature		Default	Stage	Since	Until
---------------------------------------------
CPUManager	false	Alpha	1.8	1.9
CPUManager	true	Beta	1.10	1.25
CPUManager	true	GA	1.26	–

https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features

Signed-off-by: Lee Yarwood <[email protected]>
  • Loading branch information
lyarwood committed Nov 18, 2024
1 parent 37be7d4 commit fb2a713
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion cluster-provision/gocli/opts/nodes/testconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ func AddExpectCalls(sshClient *kubevirtcimocks.MockSSHClient) {
cmds := []string{
"source /var/lib/kubevirtci/shared_vars.sh",
`timeout=30; interval=5; while ! hostnamectl | grep Transient; do echo "Waiting for dhclient to set the hostname from dnsmasq"; sleep $interval; timeout=$((timeout - interval)); [ $timeout -le 0 ] && exit 1; done`,
`echo "KUBELET_EXTRA_ARGS=--cgroup-driver=systemd --runtime-cgroups=/systemd/system.slice --kubelet-cgroups=/systemd/system.slice --fail-swap-on=false --feature-gates=NodeSwap=true,CPUManager=true --cpu-manager-policy=static --kube-reserved=cpu=500m --system-reserved=cpu=500m" | tee /etc/sysconfig/kubelet > /dev/null`,
`echo "KUBELET_EXTRA_ARGS=--cgroup-driver=systemd --runtime-cgroups=/systemd/system.slice --kubelet-cgroups=/systemd/system.slice --fail-swap-on=false --feature-gates=NodeSwap=true --cpu-manager-policy=static --kube-reserved=cpu=500m --system-reserved=cpu=500m" | tee /etc/sysconfig/kubelet > /dev/null`,
"systemctl daemon-reload && service kubelet restart",
"swapoff -a",
"until ip address show dev eth0 | grep global | grep inet6; do sleep 1; done",
Expand Down
1 change: 0 additions & 1 deletion cluster-up/cluster/kind/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ function _add_kubeadm_cpu_manager_config_patch() {
kind: JoinConfiguration
nodeRegistration:
kubeletExtraArgs:
"feature-gates": "CPUManager=true"
"cpu-manager-policy": "static"
"kube-reserved": "cpu=500m"
"system-reserved": "cpu=500m"
Expand Down

0 comments on commit fb2a713

Please sign in to comment.