Allow setting custom KUBECONFIG #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
do-not-merge/work-in-progress
In order to allow cluster-sync providers that were not created by the default scripts in this repo, allow setting custom KUBECONFIG which is all needed for cluster-sync and test-e2e targets. Signed-off-by: Or Shoval <[email protected]>
kubevirt-bot
removed
the
do-not-merge/work-in-progress
qinqon
approved these changes
Sep 3, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
oshoval
added a commit
to oshoval/cluster-network-addons-operator
that referenced
this pull request
Sep 9, 2024
Since kubevirt/ipam-extensions#60 allows custom kubeconfig, we should set the line before cluster-up, so it won't take the value set by automation/components-functests.setup.sh which is correct only for kubevirtci providers, not for external ones. Hence set it just before cluster-up. Signed-off-by: Or Shoval <[email protected]>
kubevirt-bot
pushed a commit
to kubevirt/cluster-network-addons-operator
that referenced
this pull request
Sep 9, 2024
* bump kubevirt-ipam-controller to v0.1.7-alpha Signed-off-by: Or Shoval <[email protected]> * ipam,e2e: Fix kubeconfig Since kubevirt/ipam-extensions#60 allows custom kubeconfig, we should set the line before cluster-up, so it won't take the value set by automation/components-functests.setup.sh which is correct only for kubevirtci providers, not for external ones. Hence set it just before cluster-up. Signed-off-by: Or Shoval <[email protected]> --------- Signed-off-by: Or Shoval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order to allow
cluster-syncfor providers that were notcreated by the default scripts in this repo,
allow setting custom
KUBECONFIGwhich is all neededfor
cluster-syncandtest-e2etargets.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: