-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump kubevirt-ipam-controller to v0.1.7-alpha #1887
Conversation
Signed-off-by: Or Shoval <[email protected]>
Skipping CI for Draft Pull Request. |
/test pull-e2e-cnao-kube-secondary-dns-functests i just want to see the base ref of it |
Since kubevirt/ipam-extensions#60 allows custom kubeconfig, we should set the line before cluster-up, so it won't take the value set by automation/components-functests.setup.sh which is correct only for kubevirtci providers, not for external ones. Hence set it just before cluster-up. Signed-off-by: Or Shoval <[email protected]>
Quality Gate passedIssues Measures |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-e2e-cnao-multus-dynamic-networks-functests |
What this PR does / why we need it:
Beside the bump, adapt the automation script for this bump:
Since kubevirt/ipam-extensions#60
allows custom kubeconfig, we should set the line before cluster-up,
so it won't take the value set by automation/components-functests.setup.sh
which is correct only for kubevirtci providers, not for external ones.
Hence set it just before cluster-up.
Special notes for your reviewer:
Release note: