Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kubevirt-ipam-controller to v0.1.7-alpha #1887

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Sep 9, 2024

What this PR does / why we need it:
Beside the bump, adapt the automation script for this bump:
Since kubevirt/ipam-extensions#60
allows custom kubeconfig, we should set the line before cluster-up,
so it won't take the value set by automation/components-functests.setup.sh
which is correct only for kubevirtci providers, not for external ones.
Hence set it just before cluster-up.

Special notes for your reviewer:

Release note:

bump kubevirt-ipam-controller to v0.1.7-alpha

@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 9, 2024
@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 9, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 9, 2024

/test pull-e2e-cnao-kube-secondary-dns-functests

i just want to see the base ref of it

@oshoval oshoval marked this pull request as ready for review September 9, 2024 07:29
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@oshoval oshoval marked this pull request as draft September 9, 2024 07:59
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
Since kubevirt/ipam-extensions#60
allows custom kubeconfig, we should set the line before cluster-up,
so it won't take the value set by automation/components-functests.setup.sh
which is correct only for kubevirtci providers, not for external ones.
Hence set it just before cluster-up.

Signed-off-by: Or Shoval <[email protected]>
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 9, 2024

@oshoval oshoval marked this pull request as ready for review September 9, 2024 08:26
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@kubevirt-bot kubevirt-bot requested a review from RamLavi September 9, 2024 08:26
Copy link

sonarqubecloud bot commented Sep 9, 2024

@qinqon
Copy link
Collaborator

qinqon commented Sep 9, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 9, 2024

/test pull-e2e-cnao-multus-dynamic-networks-functests

@kubevirt-bot kubevirt-bot merged commit d13a070 into kubevirt:main Sep 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants