Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support primary network #36

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

qinqon
Copy link
Collaborator

@qinqon qinqon commented Jul 4, 2024

What this PR does / why we need it:

This PR add support for ovn-kubernetes primary networks by doing a pair of things:

  • Creating an IPAMClaim if there is a primary network at namespace
  • Annotating the virt-launcher pod with k8s.ovn.org/ovn-udn-ipamclaim-reference

TODO:

  • controller unit test
  • webhook unit test
  • e2e test

Release note:

Support ovn-kubernetes primary network feature.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 4, 2024
@kubevirt-bot kubevirt-bot requested review from maiqueb and oshoval July 4, 2024 15:45
@qinqon qinqon force-pushed the support-primary-network branch 7 times, most recently from 0f17bd1 to 57ed76b Compare July 10, 2024 10:24
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2024
@qinqon qinqon closed this Sep 2, 2024
@qinqon qinqon reopened this Sep 2, 2024
@qinqon qinqon force-pushed the support-primary-network branch from 57ed76b to 5d0f585 Compare September 3, 2024 05:41
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2024
@qinqon qinqon force-pushed the support-primary-network branch 12 times, most recently from 401c7cd to ba3e59f Compare September 3, 2024 14:11
@qinqon qinqon force-pushed the support-primary-network branch 9 times, most recently from c9a04e0 to 4111655 Compare September 4, 2024 14:36
@qinqon qinqon requested a review from maiqueb September 4, 2024 14:38
pkg/config/types.go Outdated Show resolved Hide resolved
pkg/udn/primary_network.go Outdated Show resolved Hide resolved
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
@qinqon qinqon requested a review from maiqueb September 4, 2024 15:51
@qinqon qinqon force-pushed the support-primary-network branch from 4111655 to bdabec2 Compare September 5, 2024 06:42
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Let's get this one in now.

Thanks, good work.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@kubevirt-bot kubevirt-bot merged commit 7348bbf into kubevirt:main Sep 5, 2024
4 checks passed
@RamLavi
Copy link
Contributor

RamLavi commented Sep 8, 2024

I like how this makes the webhook Handle function much more readable
/lgtm

@oshoval
Copy link
Collaborator

oshoval commented Sep 8, 2024

i guess we want it to be deployed by CNAO
for that please create a tag so it would be bumped on CNAO (EDIT - done)
and then need to also backport it to stable CNAO branch 0.95.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants