WIP: Primary udn integration #59
Conversation
kubevirt-bot
added
do-not-merge/work-in-progress
maiqueb
requested review from
qinqon and
oshoval
and removed request for
qinqon
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
to review it or it is wip ? |
WIP |
maiqueb
force-pushed
the
primary-udn-integration
branch
4 times, most recently
from
0254a3b to
303e01f
Compare
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
primary-udn-integration
branch
from
303e01f to
d145131
Compare
| return controllerruntime.Result{}, err | ||
| } | ||
| if primaryUDN != nil { | ||
| claimKey := fmt.Sprintf("%s.%s-primary-udn", vmi.Name, primaryUDN.Name) |
There was a problem hiding this comment.
We should normalize the key to follow k8s naming conventions, I have see errors like the following when the network name at the NAD has unexpected chars.
Retry add failed for *v1.Pod kv-live-migration-8805/virt-launcher-worker1-987pq, will try again later: failed to update pod kv-live-migration-8805/virt-launcher-worker1-987pq: error retrieving IPAMClaim for pod kv-live-migration-8805/virt-launcher-worker1-987pq: failed to get IPAMClaim "worker1.jv45k_net1-primary-udn": ipamclaim.k8s.cni.cncf.io "worker1.jv45k_net1-primary-udn" not found
|
Abandoned in-lieu of #36 . Didn't notice that PR existed, sorry about that. |
What this PR does / why we need it:
This PR instructs OVN-K of the IPAMClaim name to be used for the primary UDN feature.
We could have hard-coded instead the name, but then, we would need to understand which workload really wants persistent IPs on OVN-K - i.e. it would have to identify if it is allocating for a VM or a pod.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
WIP. PLEASE DO NOT merge.
Release note: