Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Always pull policy for virt-v2v #1112

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Oct 18, 2024

Issue:
When running the virt-v2v with the latest tag it does not pull the updated image.

@mnecas mnecas requested a review from yaacov as a code owner October 18, 2024 08:41
@mnecas
Copy link
Member Author

mnecas commented Oct 18, 2024

Related to: #1048 (comment)

Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.66%. Comparing base (bc87852) to head (03a0ff1).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/plan/kubevirt.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
- Coverage   16.20%   15.66%   -0.54%     
==========================================
  Files         112      112              
  Lines       19882    23052    +3170     
==========================================
+ Hits         3222     3612     +390     
- Misses      16375    19155    +2780     
  Partials      285      285              
Flag Coverage Δ
unittests 15.66% <0.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas merged commit d045987 into kubev2v:main Oct 18, 2024
32 of 35 checks passed
@jsakil14
Copy link

My csv below:

  • name: CONTROLLER_IMAGE
    value: quay.io/kubev2v/forklift-controller:latest
    - name: API_IMAGE
    value: quay.io/kubev2v/forklift-api:latest
    - name: MUST_GATHER_IMAGE
    value: quay.io/kubev2v/forklift-must-gather:latest
    - name: UI_PLUGIN_IMAGE
    value: quay.io/kubev2v/forklift-console-plugin:latest
    - name: VALIDATION_IMAGE
    value: quay.io/kubev2v/forklift-validation:latest
    - name: VIRT_V2V_IMAGE
    value: quay.io/kubev2v/forklift-virt-v2v:latest
    - name: VIRT_V2V_WARM_IMAGE
    value: quay.io/kubev2v/forklift-virt-v2v-warm:latest
    - name: VIRT_V2V_DONT_REQUEST_KVM
    - name: SNAPSHOT_REMOVAL_TIMEOUT
    - name: SNAPSHOT_STATUS_CHECK_RATE
    - name: CLEANUP_RETRIES
    - name: CDI_EXPORT_TOKEN_TTL
    - name: FILESYSTEM_OVERHEAD
    - name: BLOCK_OVERHEAD
    - name: POPULATOR_CONTROLLER_IMAGE
    value: quay.io/kubev2v/populator-controller:latest
    - name: OVIRT_POPULATOR_IMAGE
    value: quay.io/kubev2v/ovirt-populator:latest
    - name: OPENSTACK_POPULATOR_IMAGE
    value: quay.io/kubev2v/openstack-populator:latest
    - name: OVA_PROVIDER_SERVER_IMAGE
    value: quay.io/kubev2v/forklift-ova-provider-server:latest
    - name: OVIRT_OS_MAP
    - name: VSPHERE_OS_MAP
    - name: VIRT_CUSTOMIZE_CONFIGMAP_NAME
    value: forklift-virt-customize
    image: quay.io/kubev2v/forklift-operator:latest
    imagePullPolicy: Always

But , still deployed migration pod is showing - libguestfs: trace: virtio_win: disk_create "/tmp/libguestfsAXRn92/overlay1.qcow2" "qcow2" -1 "backingfile:/usr/share/virtio-win/virtio-win-1.9.15.iso"
libguestfs: trace: virtio_win: disk_format "/usr/share/virtio-win/virtio-win-1.9.15.iso" @mnecas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants