Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1483 | Fix virtio-win driver version #1048

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mnecas
Copy link
Member

@mnecas mnecas commented Sep 19, 2024

Issue:
The Centos 9 AppStream repo has an outdated Windows virtio driver which does not support Windows 2022 and has issues with 2019. This change updates the rpm to the fedora package.

This is not a proper fix but WA as the base image is ubi9 and we should not mix the packages.

Fixes: #982
Fixes: #1029
Fixes: https://issues.redhat.com/browse/MTV-1483

@mnecas mnecas requested a review from yaacov as a code owner September 19, 2024 14:05
@mnecas mnecas marked this pull request as draft September 19, 2024 14:07
@mnecas
Copy link
Member Author

mnecas commented Sep 19, 2024

Moving to draft as I'm not sure if I want to go this route

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.20%. Comparing base (31037e9) to head (b49c04c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   16.25%   16.20%   -0.05%     
==========================================
  Files         112      112              
  Lines       19882    19882              
==========================================
- Hits         3231     3222       -9     
- Misses      16364    16375      +11     
+ Partials      287      285       -2     
Flag Coverage Δ
unittests 16.20% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas changed the title Fix virtio-win driver version MTV-1483 | Fix virtio-win driver version Sep 19, 2024
Issue:
The centos 9 AppStream repo has outdated windows virtio driver.
This change updates the rpm to the fedora package.

Signed-off-by: Martin Necas <[email protected]>
@mnecas mnecas force-pushed the fix_virt-v2v-build branch from 2cab2e3 to b49c04c Compare October 17, 2024 07:51
@mnecas mnecas marked this pull request as ready for review October 17, 2024 07:51
Copy link

@mnecas
Copy link
Member Author

mnecas commented Oct 17, 2024

Got build from koji for el9, moving from draft

@mnecas mnecas merged commit 14cf8cb into kubev2v:main Oct 17, 2024
23 of 34 checks passed
@jsakil14
Copy link

Got build from koji for el9, moving from draft

Will this be pushed to virt-v2v image in quay.io/kubev2v registry? Since , am using olm - I tried build now with the :latest - still its pointing to virtio-win-1.9.15.iso. Or do we still need to rebuild it only with bazel? @mnecas

@mnecas
Copy link
Member Author

mnecas commented Oct 18, 2024

@jsakil14 strange, it should be updated, let me check.

@mnecas
Copy link
Member Author

mnecas commented Oct 18, 2024

I opened #1112 you will need to update the controller image after it, hope it will help

@jsakil14
Copy link

jsakil14 commented Nov 4, 2024

@mnecas was this pushed?

@arturshadnik
Copy link
Contributor

Hi @mnecas just following up on this, the :latest image from quay.io/kubev2v seems to still have the older 1.9.15 version.
image. When building locally from main, the build fails trying to fetch the updated virtio-win driver. Can you please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants