-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐾 Add a plan details item to edit boot disk #1205
Conversation
@bkhizgiy hi, please take a look, Notes:
Example o spec.vms with rootDisk: vms:
- id: vm-55
name: DC0_H0_VM0
rootDisk: '2'
- id: vm-58
name: DC0_H0_VM1
rootDisk: '2'
- id: vm-61
name: DC0_C0_RP0_VM0
rootDisk: '2'
- id: vm-64
name: DC0_C0_RP0_VM1
rootDisk: '2' |
waiting for: kubev2v/forklift#873 |
Following our conversation, we have decided to update the string input in the UI to specify both the disk and partition the user wishes to set as the root. For example: For the first disk, please use the input For help text we can add something of a sort: |
75e9c0c
to
8743e5e
Compare
Quality Gate passedIssues Measures |
@bkhizgiy hi, updates: export const diskOptions = (t = (text: string) => text): DiskOption[] => [
{ key: '', description: t('Boot from first root device') },
{ key: 'sda', description: t('Boot from the first hard drive') },
{
key: 'sda1',
description: t('Boot from the first partition on the first hard drive'),
},
{
key: 'sda2',
description: t('Boot from the second partition on the first hard drive'),
},
{ key: 'sdb', description: t('Boot from the second hard drive') },
{
key: 'sdb1',
description: t('Boot from the first partition on the second hard drive'),
},
{
key: 'sdb2',
description: t('Boot from the second partition on the second hard drive'),
},
]; c. user can create new root device strings that are not in the pre defined options vms:
- id: vm-23113
name: mtv-rhel8-warm-sanity-nfs
rootDisk: sdd
- id: vm-23159
name: mtv-rhel8-warm-sanity
rootDisk: sdd e. i also updated the description screenshots |
@bkhizgiy hi, vms:
- id: vm-23113
name: mtv-rhel8-warm-sanity-nfs
rootDisk: /dev/sda1
- id: vm-23159
name: mtv-rhel8-warm-sanity
rootDisk: /dev/sda1 |
6d53343
to
a682f81
Compare
Signed-off-by: yaacov <[email protected]>
Ref: #1192
Allow users to set the plan rootDisk
Screenshots:
Screencast.from.2024-06-17.14-58-51.mp4