Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 let the user choose the boot disk for multiboot #1192

Closed
yaacov opened this issue Jun 3, 2024 · 4 comments
Closed

🐾 let the user choose the boot disk for multiboot #1192

yaacov opened this issue Jun 3, 2024 · 4 comments
Assignees
Labels
enhancement Categorizes issue or PR as related to a new feature.
Milestone

Comments

@yaacov
Copy link
Member

yaacov commented Jun 3, 2024

Ref: kubev2v/forklift#930

Support: plan.vms[n].rootDisk {string}

@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Jun 3, 2024
@yaacov yaacov added this to the 2.7.0 milestone Jun 3, 2024
@yaacov
Copy link
Member Author

yaacov commented Jun 3, 2024

@bkhizgiy hi,
a. do you know how the "rootDisk" parameter will be used ?
( for example, is it going to be a number e.g. "1" - first disk (default) "2" - second disk ? )
b. do you plan it to be a plan thing, e.g. all the vms will have the same rootDisk value ?

@yaacov
Copy link
Member Author

yaacov commented Jun 3, 2024

@bkhizgiy
Copy link
Member

bkhizgiy commented Jun 3, 2024

@yaacov Hi, we just had this conversation yesterday:) I'm still thinking about the best way for the user to specify this property. We were considering passing a number like you suggested; I just need to check if it can be processed correctly in the backend. I'll update here once we have a final conclusion.

And no, I think it should be applicable for OVA as well. From virt-v2v, I saw it's possible to do in OVA conversions as well, so I think we should support all flows.

@yaacov yaacov modified the milestones: 2.7.0, 2.6.3 Jun 6, 2024
@yaacov yaacov self-assigned this Jun 7, 2024
@yaacov
Copy link
Member Author

yaacov commented Jun 18, 2024

addressed by: #1205

@yaacov yaacov closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants