Add a new workflow for concretization and delete older concretization workflows #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Sep 16, 2024
Comment on lines
+47
to
+48
| git clone https://github.com/spack/spack -q | ||
| source spack/share/spack/setup-env.sh |
There was a problem hiding this comment.
This could be a
- uses: actions/checkout@v4
with:
repo: spack/spack
path: spackat the top. Potentially, even ref: $(cat ${GITHUB_WORKSPACE}/.latest-commit) works, but since we need the history of develop as well, we would then also have to tweak the fetch-depth, so I am not sure whether it's worth it to specify that here.
There was a problem hiding this comment.
Yeah, I'm not sure. The checkout action seems to do more things and sometimes it takes more than a simple clone.
jmcarcell
changed the title
|
I'll merge this so it can be used for other PRs even though the issue described in github.com/orgs/community/discussions/63579 is happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow will run concretization on alma9 and ubuntu22 with the environments that are used for the release and nightly builds. They have the issue shown in https://github.com/orgs/community/discussions/63579 but I think it's good enough.