Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the conversion script exit early if include statements are found in the XML inputs #148

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Oct 5, 2023

BEGINRELEASENOTES

  • Add a warning message to the steering file converter script to warn users about any <include ref="..." /> statements in the original Marlin steering file.

ENDRELEASENOTES

@andresailer is a warning enough or should we even just exit with non-zero in this case?

@tmadlener tmadlener changed the title Warn if any unresolved include statement is found Make the conversion script exit early if include statements are found in the XML inputs Nov 2, 2023
@tmadlener tmadlener merged commit 33b3792 into key4hep:main Nov 2, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant