Skip to content

Commit

Permalink
Warn if any unresolved include statement is found (#148)
Browse files Browse the repository at this point in the history
  • Loading branch information
tmadlener authored Nov 2, 2023
1 parent 17981e9 commit 33b3792
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions k4MarlinWrapper/scripts/convertMarlinSteeringToGaudi.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,6 @@ def convertConstants(lines, tree):
""" Find constant tags, write them to python and replace constants within themselves """
constants = dict()

constElements = tree.findall('constants/include')
if constElements:
print('WARNING: include statements found inside constants tag')

constElements = tree.findall('constants/constant')
for const in constElements:
constants[const.attrib.get('name')] = getValue(const)
Expand Down Expand Up @@ -249,7 +245,18 @@ def convertProcessors(lines, tree, globParams, constants):
return lines


def findWarnIncludes(tree):
"""Check the parsed XML structure for include statments and issue a warning"""
if any(True for _ in tree.iter("include")):
print("ERROR: Found at least one <include ref=\"...\"/> statement in the Marlin steering file")
print(" These cannot be handled by the conversion script.")
print(" Use Marlin -n <input-file> to resolve these includes and convert the output of that")

sys.exit(1)


def generateGaudiSteering(tree):
findWarnIncludes(tree)
globParams = getGlobalParameters(tree)
lines = []
createHeader(lines)
Expand Down

0 comments on commit 33b3792

Please sign in to comment.